feat: unified trade events #910
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jak-pan
reviewed
Sep 20, 2024
jak-pan
reviewed
Sep 20, 2024
jak-pan
reviewed
Sep 20, 2024
jak-pan
reviewed
Sep 20, 2024
jak-pan
reviewed
Sep 20, 2024
|
what if we call the new pallet something more generic ... eg. amm-support. it might be useful for other things, not only one specific trade event. |
pallets/trade-event/src/lib.rs
Outdated
Comment on lines
58
to
59
| who: T::AccountId, | ||
| pool: PoolType<AssetId>, |
There was a problem hiding this comment.
after discussion with @jak-pan , we suggest:
Suggested change
| who: T::AccountId, | |
| pool: PoolType<AssetId>, | |
| swapper: T::AccountId, | |
| filler: T::AccountId, // ICE acc, Omnipool acc, stablepool acc, xyk account etc.. | |
| type: FillerType, |
enum FillerType {
Omnipool,
Stableswap,
XYK,
LBP,
OTC,
ICE,
}There was a problem hiding this comment.
Who is filler in OTC?
There was a problem hiding this comment.
type is a keyword, cannot be used
There was a problem hiding this comment.
Who is
fillerin OTC?
the one filling order
There was a problem hiding this comment.
isn't it the one who owns the order?
|
Crate versions that have not been updated:
New crates:
Crate versions that have been updated:
Runtime version has not been increased. |
# Conflicts: # Cargo.lock # Cargo.toml # pallets/lbp/Cargo.toml # pallets/omnipool/Cargo.toml # pallets/otc/Cargo.toml # pallets/route-executor/Cargo.toml # pallets/stableswap/Cargo.toml
# Conflicts: # Cargo.lock # pallets/omnipool/Cargo.toml
# Conflicts: # Cargo.lock # pallets/stableswap/Cargo.toml
…to omnipool swaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #755
TODO: